Skip to content

refactor(@schematics/angular): deprecate testRunner option - #34697

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:deprecate-test-runner-option
Nov 12, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:deprecate-test-runner-option

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The testRunner option in the application, library, and ng-new schematics is not marked as deprecated.

Issue Number: N/A

What is the new behavior?

The testRunner option in the application, library, and ng-new schematics is marked as deprecated via x-deprecated, noting that new projects will only be configured with Vitest in a future version. Additionally, ng-new avoids forwarding the default vitest value to the nested application schematic so default ng new invocations do not emit a deprecation warning.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

DEPRECATED: The `testRunner` option in the `application`, `library`, and `ng-new` schematics is deprecated. New projects will only be configured with Vitest in a future version.
@angular-robot angular-robot Bot added detected: deprecation PR contains a commit with a deprecation area: @schematics/angular labels Nov 12, 2026
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release and removed area: @schematics/angular detected: deprecation PR contains a commit with a deprecation labels Nov 12, 2026
@alan-agius4
alan-agius4 requested a review from clydin November 12, 2026 09:21
@angular-robot angular-robot Bot added detected: deprecation PR contains a commit with a deprecation area: @schematics/angular labels Nov 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the unit testing runner option in the Angular schematics for applications, libraries, and new workspaces, signaling a future transition to Vitest as the exclusive test runner. Additionally, the ng-new schematic is updated to only pass the testRunner option when it is explicitly set to Karma. There are no review comments, and I have no additional feedback to provide.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 12, 2026
@alan-agius4
alan-agius4 merged commit 5bfcd66 into angular:main Nov 12, 2026
48 of 49 checks passed
@alan-agius4
alan-agius4 deleted the deprecate-test-runner-option branch November 12, 2026 12:48
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular detected: deprecation PR contains a commit with a deprecation target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants